Repository navigation
feat(report): credit rule evidence beyond review comments - #699
Conversation
Regenerates the ReportV1 schema now that tskl.es credits commits, issues, docs and tests (taskless/taskless#527), and opens the report-rule-evidence change for the CLI half. Refs #681
…ach kind Onboard credits commits, issues, code comments, agent files, docs and tests as their own kind of evidence instead of dropping everything but review comments; the report recipe defines one call-out per kind. Refs #681
|
@claude /review |
|
Claude finished @theCodeDrift's task in 2m 37s —— View job Review:
|
Rewrapped the "Show the result" step to the file's 72-column width in c9d0706; the rest of the edit had pushed the paragraph after it out of shape too, so the whole step is reflowed. No other findings to address. — AI Coding Agent |
The CLI half of rule evidence. tskl.es started accepting it in taskless/taskless#527, which is now deployed. Until now, a rule chosen from repeated fix-up commits, docs or tests published as "raised in 0 reviews", and a repository that pushes to
mainshowed zero on every rule.What changes
report-v1.schema.jsonis regenerated from the live tskl.es schema. It gains per-rulesources(seven kinds) andevidence(call-out counts per kind). Both are optional, andschemaVersionstays"1". The CLI never sent the Octobersourcesfield either, so this adds both.rules,legacy,cloud) takes optionalsourcesandevidence, which are carried to the payload unchanged. The kinds live inreport/evidence.tswith the group of each. A test holds them equal to the vendored schema, so a refresh that adds a kind fails until it is given a group.checkReportrefuses, underREPORT_INVALIDand naming the rule and the field:sourceson some rules but not allreviewswith no review commentcommits/issues/docs/testslisted without a countevidencewithoutsourcesRule a (Taskless ast-grep rule): 6 times in reviews, 1 time in conventions. They are summed and ordered the way the page does it.onboard(topic v15) tallies call-outs from every source per candidate, by kind, while mining. Commits that made the fix count ascommitsevidence, never assurfaced.report(topic v10) renames "Counting surfaced" to "Counting evidence" and defines one call-out per kind. Kinds and counts only, never paths.Facts without the new fields produce the same payload as before.
Differences from the issue
The shipped service contract names the tracker kind
issues, nottrackers. TODO/FIXME comments count asconventions. The summary shows two group totals, not a single "strongest evidence". All of it follows taskless/taskless#527's design.Verification
pnpm typecheck,pnpm lint,pnpm test(3348 passed).cli-reportandcli-onboardand added 12 new ones.report-rule-evidenceis archived in this PR.Post-merge: publish an onboarding report from a repository with no PR history and confirm its rules show "times in reviews" / "times in conventions" on the page.
Fixes #681